Skip to content

Update libclamav.map with missing symbols#1159

Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom
neiwilso:libclamav-map
Mar 12, 2024
Merged

Update libclamav.map with missing symbols#1159
val-ms merged 1 commit intoCisco-Talos:mainfrom
neiwilso:libclamav-map

Conversation

@neiwilso
Copy link
Contributor

@neiwilso neiwilso commented Jan 29, 2024

Linker errors when supplying local unrar interface

[2024-01-25T17:38:36.469Z] : && g++   clamshell/clamshell_unpriv/CMakeFiles/clamshell-bin.dir/main.cpp.o clamshell/clamshell_unpriv/CMakeFiles/clamshell-bin.dir/crash_handler_crashpad.cpp.o -o clamshell/clamshell_unpriv/clamshell -L/home/jenkins/workspace/Cloud_ampcx_PR-7032/ampcx/build/debug/export/lib -Wl,-rpath,/home/jenkins/workspace/Cloud_ampcx_PR-7032/ampcx/build/debug/export/lib::::::::  src/libclamshell_unpriv.a  -lclamav  -lclamunrar_iface  -lclamunrar  -lclammspack  -Wl,-Bstatic  -lpcre2-8  -lssl  -lcrypto  -lxml2  -Wl,-Bdynamic  -lcrashpad_handler_lib  -lcrashpad_client  -lcrashpad_common  -lcrashpad_minidump  -lcrashpad_snapshot  -lcrashpad_common  -lcrashpad_context  -lcrashpad_net  -lcrashpad_util  -lcrashpad_base  -lz  -lrt  -lpthread  -lm  -ldl  -lbz2  -lstdc++  -lcrashpad_minidump  -lcrashpad_snapshot  -lcrashpad_context  -lcrashpad_net  -lcrashpad_util  -lcrashpad_base  -lz  -lrt  -lpthread  -lm  -ldl  -lbz2  -lstdc++ && :

[2024-01-25T17:38:36.469Z] /usr/bin/ld: src/libclamshell_unpriv.a(clamshell_unrar.c.o): in function `cs_unrar_enable':
[2024-01-25T17:38:36.469Z] clamshell_unrar.c:(.text+0x7): undefined reference to `cli_unrar_open'
[2024-01-25T17:38:36.469Z] /usr/bin/ld: clamshell_unrar.c:(.text+0x18): undefined reference to `cli_unrar_peek_file_header'
[2024-01-25T17:38:36.469Z] /usr/bin/ld: clamshell_unrar.c:(.text+0x29): undefined reference to `cli_unrar_extract_file'
[2024-01-25T17:38:36.469Z] /usr/bin/ld: clamshell_unrar.c:(.text+0x3a): undefined reference to `cli_unrar_skip_file'
[2024-01-25T17:38:36.469Z] /usr/bin/ld: clamshell_unrar.c:(.text+0x4b): undefined reference to `cli_unrar_close'

Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me. I will have to confirm they don't break anything weird in CI/CD.

Also, we're on our 2nd release candidate for 1.3.0. So we should probably hold off until after 1.3.0 ships and have this go towards 1.4.0.

@val-ms val-ms merged commit 5e63c42 into Cisco-Talos:main Mar 12, 2024
@val-ms val-ms added the 🍒cherry-pick-candidate A PR that should be backported once approved. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒cherry-pick-candidate A PR that should be backported once approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants